Fix panic while processing Zipkin spans with empty service name #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XSAM
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
XSAM
force-pushed
the
fix/zipkin-receiver-panic
branch
from
c7fe750 to
c2c5c84
Compare
Codecov Report
@@ Coverage Diff @@
## master #1742 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 256 256
Lines 18190 18190
=======================================
Hits 16806 16806
Misses 970 970
Partials 414 414
Continue to review full report at Codecov.
|
|
Oh, nice! I have encountered the same problem just a while ago. Saw the PR, tested it with my payload and it fixes the problem for me |
bogdandrutu
approved these changes
Sep 5, 2020
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…etry#1742) Bumps [requests](https://github.com/psf/requests) from 2.28.0 to 2.28.1. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.28.0...v2.28.1) --- updated-dependencies: - dependency-name: requests dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix a panic issue while processing Zipkin spans with an empty service name.
Testing:
receiver/zipkinreceiver/TestConvertSpansToTraceSpans_JSONWithoutSerivceName