Add metrics to groupbytraceprocessor, wait for queue to be drained during shutdown. #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
jpkrohling
force-pushed
the
jpkrohling/1465-shutdown-behavior-for-groupbyprocessor
branch
from
ea29c21 to
2ccd3d8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1842 +/- ##
========================================
Coverage 91.23% 91.24%
========================================
Files 272 273 +1
Lines 16263 16383 +120
========================================
+ Hits 14838 14949 +111
- Misses 998 1003 +5
- Partials 427 431 +4
Continue to review full report at Codecov.
|
jpkrohling
force-pushed
the
jpkrohling/1465-shutdown-behavior-for-groupbyprocessor
branch
3 times, most recently
from
9ecf89f to
793b1e2
Compare
|
The last commit in this PR fixes #1811. |
jpkrohling
force-pushed
the
jpkrohling/1465-shutdown-behavior-for-groupbyprocessor
branch
from
6277807 to
be3e69b
Compare
jpkrohling
force-pushed
the
jpkrohling/1465-shutdown-behavior-for-groupbyprocessor
branch
2 times, most recently
from
c037b65 to
99f90b5
Compare
* Drain the queue upon shutdown, with a time limit. Fixes open-telemetry#1465. * Added metrics to the groupbyprocessor, making it easier to understand what's going on in case of problems. See open-telemetry#1811. * Changes the in-memory storage to unlock its RLock when the method returns. Fixes open-telemetry#1811. Link to tracking Issue: open-telemetry#1465 and open-telemetry#1811 Testing: unit + manual tests Documentation: see README.md Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling
force-pushed
the
jpkrohling/1465-shutdown-behavior-for-groupbyprocessor
branch
from
99f90b5 to
afcb27a
Compare
|
@tigrannajaryan, @bogdandrutu , would one of you please review this, or assign someone to review it? I just discussed this with @chris-smith-zocdoc and he confirmed that this fixes the issue he described. A couple of separate issues were found, but we'll address that after the move of this processor to the -contrib repository. I would really like to get this merged before the move, so that I have only one thing to move. |
| @@ -39,9 +37,6 @@ func TestDefaultConfiguration(t *testing.T) { | |||
| func TestCreateTestProcessor(t *testing.T) { | |||
| c := createDefaultConfig().(*Config) | |||
|
|
|||
| logger, err := zap.NewDevelopment() | |||
| require.NoError(t, err) | |||
|
|
|||
| params := component.ProcessorCreateParams{ | |||
| Logger: logger, | |||
There was a problem hiding this comment.
It's not apparent to me what this logger is now
There was a problem hiding this comment.
This is defined in the processor_test.go as:
var (
logger, _ = zap.NewDevelopment()
)
rmfitzpatrick
approved these changes
Sep 30, 2020
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
|
PR updated with the corrected number of buffered events. |
tigrannajaryan
approved these changes
Oct 1, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed deadlock in groupbytrace processor.
Link to tracking Issue: #1465 and #1811
Testing: unit + manual tests
Documentation: see README.md
Signed-off-by: Juraci Paixão Kröhling [email protected]