Do not inherit cancellation in the async sending queue #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
requested review from
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1930 +/- ##
==========================================
- Coverage 91.41% 91.40% -0.01%
==========================================
Files 284 284
Lines 16740 16744 +4
==========================================
+ Hits 15303 15305 +2
- Misses 1007 1008 +1
- Partials 430 431 +1
Continue to review full report at Codecov.
|
tigrannajaryan
approved these changes
Oct 9, 2020
Signed-off-by: Bogdan Drutu <[email protected]>
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
Co-authored-by: Anthony Mirabella <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…n-telemetry#1930) * Support installing with ansible and skipping restart of services * move to start_service add when clause on test to avoid failing on suse * join the clauses to restart for td-agent * reload systemd even if we're not restarting the service * Update deployments/ansible/roles/collector/README.md Co-authored-by: Jeff Cheng <[email protected]> * Add to role variables README * test for service stopped first, don't test for td-agent * add start_service in default role vars Co-authored-by: Jeff Cheng <[email protected]> Co-authored-by: Ryan Fitzpatrick <[email protected]>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu [email protected]
Fixes #1813