Use Component for start/shutdown of the Scraper #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a followup PR, after open-telemetry#2186 is merged, use component helper. Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
scrapercomp
branch
from
2e224dd to
5da3a90
Compare
Codecov Report
@@ Coverage Diff @@
## master #2187 +/- ##
=======================================
Coverage 91.99% 92.00%
=======================================
Files 270 270
Lines 15791 15784 -7
=======================================
- Hits 14527 14522 -5
+ Misses 860 859 -1
+ Partials 404 403 -1
Continue to review full report at Codecov.
|
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a followup PR, after #2186 is merged, use component helper.
Signed-off-by: Bogdan Drutu [email protected]