-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving fluentforwardreceiver to contrib repo. #2723
Moving fluentforwardreceiver to contrib repo. #2723
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2723 +/- ##
==========================================
+ Coverage 91.64% 91.77% +0.13%
==========================================
Files 290 281 -9
Lines 15541 15131 -410
==========================================
- Hits 14242 13886 -356
+ Misses 889 852 -37
+ Partials 410 393 -17
Continue to review full report at Codecov.
|
@paulosman the E2E tests failed, I think you need to delete TestLog10kDPS/FluentBitToOTLP too. |
Also, please fix the merge conflict. |
57c00e6
to
666755b
Compare
Thanks @tigrannajaryan . I moved the test, now it's failing in the contrib repo, unfortunately. I can try bumping the resourcespec and seeing if that fixes it.
|
666755b
to
c807834
Compare
Please also clean the CI config, remove these bits:
|
Thanks, this is done. Looks like there are still two checks failing, (contrib_tests and check-links) but they appear to be failing all builds right now? |
Oh now... please rebase |
84a7618
to
1e32169
Compare
Done, now there are new failures :-) Something to do with ports - I can try and debug later today. |
1e32169
to
27586fc
Compare
27586fc
to
1d55ed2
Compare
Rebased again and they're passing - think I just got unlucky. @bogdandrutu there's a failure in contrib-tests that looks related to the rename of configmodels => config. Let me know if you want me to try and address that here, otherwise I think this is PR ready to go. |
Description:
This is one of two PRs intended to address #2675. This PR removes fluentforwardreceiver from this repo, the other adds it to the opentelemetry-collector-contrib repo.
Contrib repo PR: open-telemetry/opentelemetry-collector-contrib#2729
Link to tracking Issue:
#2675
Testing:
Confirmed that the project builds locally.