Add AppendEmpty and deprecate Append for slices #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change helps with initialization: * Lots of places where we used Resize(1). Some left to limit the PR. * Lots of places where New followed by Append, this is equivalent with AppendEmpty. Append is marked as deprecated, but we need to evaluate if we can change all calls to AppendEmpty, or we need to revert the deprecation. The current goal is to remove it if possible. Signed-off-by: Bogdan Drutu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2970 +/- ##
==========================================
+ Coverage 91.62% 91.64% +0.01%
==========================================
Files 312 312
Lines 15364 15388 +24
==========================================
+ Hits 14078 14102 +24
Misses 880 880
Partials 406 406
Continue to review full report at Codecov.
|
jrcamp
approved these changes
Apr 20, 2021
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Apr 21, 2021
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
added a commit
that referenced
this pull request
Apr 21, 2021
Signed-off-by: Bogdan Drutu <[email protected]>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…en-telemetry#2970) Bumps [github.com/go-sql-driver/mysql](https://github.com/go-sql-driver/mysql) from 1.4.0 to 1.7.0. - [Release notes](https://github.com/go-sql-driver/mysql/releases) - [Changelog](https://github.com/go-sql-driver/mysql/blob/master/CHANGELOG.md) - [Commits](go-sql-driver/mysql@v1.4.0...v1.7.0) --- updated-dependencies: - dependency-name: github.com/go-sql-driver/mysql dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change helps with initialization:
Append is marked as deprecated, but we need to evaluate if we can change all calls to AppendEmpty,
or we need to revert the deprecation. The current goal is to remove it if possible.
Signed-off-by: Bogdan Drutu [email protected]