Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename service.Application to service.Collector #3268

Merged
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
3820712
Create snyk-container-analysis.yml
xukaren May 14, 2021
06207ea
Merge branch 'open-telemetry:main' into main
eddyleelin May 16, 2021
97056a9
Create snyk-container-analysis.yml
xukaren May 14, 2021
eca1e91
Merge branch 'main' of https://github.com/open-o11y/opentelemetry-col…
IrisTuntun May 17, 2021
751671e
Renamed occurrences of Application to Collector
eddyleelin May 19, 2021
184c40f
Rename more instances of Application to Collector
eddyleelin May 19, 2021
052263c
Renamed references of service.Application to collector (or collector …
eddyleelin May 20, 2021
940f66c
Added change log entry stub
eddyleelin May 20, 2021
3834ad4
Added number of PR
eddyleelin May 21, 2021
0841f15
Merge remote-tracking branch 'origin/rename-serviceApplication' into …
eddyleelin May 21, 2021
7bddd67
Fixed merge conflicts
eddyleelin May 21, 2021
21a2e86
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
eddyleelin May 24, 2021
31f6c35
Update CHANGELOG.md
eddyleelin May 24, 2021
16ec914
Merge branch 'main' into rename-serviceApplication-resolved
eddyleelin May 26, 2021
9497898
Merge branch 'main' into rename-serviceApplication-resolved
eddyleelin May 27, 2021
e9db9fb
Renamed ColSettings to CollectorSettings
eddyleelin May 27, 2021
2e2c650
Merge branch 'main' of https://github.com/open-o11y/opentelemetry-col…
eddyleelin May 27, 2021
9f9a992
Merge branch 'main' into rename-serviceApplication-resolved
eddyleelin May 27, 2021
0430b73
Fixed naming error
eddyleelin May 27, 2021
586b7e8
Delete snyk-container-analysis.yml
eddyleelin Jun 2, 2021
3dd5378
Merge branch 'open-telemetry:main' into rename-serviceApplication-res…
eddyleelin Jun 3, 2021
4e7b87a
Merge branch 'open-telemetry:main' into rename-serviceApplication-res…
eddyleelin Jun 3, 2021
427815a
Merge remote-tracking branch 'upstream/main' into rename-serviceAppli…
eddyleelin Jun 12, 2021
4d72df5
Moved change log entry unreleased section
eddyleelin Jun 12, 2021
f5f0062
Deleted extra new line in change log
eddyleelin Jun 12, 2021
e9bfc93
Merge branch 'main' into rename-serviceApplication-resolved
eddyleelin Jun 14, 2021
46456b2
Merge branch 'open-telemetry:main' into rename-serviceApplication-res…
eddyleelin Jun 14, 2021
5d1987d
Renamed occurrences of Application to Collector
eddyleelin May 19, 2021
0819c2d
Rename more instances of Application to Collector
eddyleelin May 19, 2021
498703f
Renamed references of service.Application to collector (or collector …
eddyleelin May 20, 2021
8c89d8b
Added number of PR
eddyleelin May 21, 2021
5491db6
Fixed merge conflicts
eddyleelin May 21, 2021
9ad89b3
Renamed ColSettings to CollectorSettings
eddyleelin May 27, 2021
3afa4f1
Fixed naming error
eddyleelin May 27, 2021
41cd4ab
Moved change log entry unreleased section
eddyleelin Jun 12, 2021
ad55466
Merge branch 'rename-serviceApplication-resolved' of https://github.c…
eddyleelin Jun 14, 2021
e4fb185
Removed misplaced newline
eddyleelin Jun 14, 2021
cc28dd2
Merge branch 'open-telemetry:main' into rename-serviceApplication-res…
eddyleelin Jun 15, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Remove unused logstest package (#3222)
- Introduce `AppSettings` instead of `Parameters` (#3163)
- Rename `service.Application` to `service.Collector` (#3268)
eddyleelin marked this conversation as resolved.
Show resolved Hide resolved
- Remove unused testutil.TempSocketName (#3291)
- Move BigEndian helper functions in `tracetranslator` to an internal package.(#3298)

Expand Down
8 changes: 4 additions & 4 deletions cmd/otelcol/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,20 +37,20 @@ func main() {
Version: version.Version,
}

if err := run(service.AppSettings{BuildInfo: info, Factories: factories}); err != nil {
if err := run(service.ColSettings{BuildInfo: info, Factories: factories}); err != nil {
log.Fatal(err)
}
}

func runInteractive(settings service.AppSettings) error {
func runInteractive(settings service.ColSettings) error {
app, err := service.New(settings)
if err != nil {
return fmt.Errorf("failed to construct the application: %w", err)
return fmt.Errorf("failed to construct the collector server: %w", err)
}

err = app.Run()
if err != nil {
return fmt.Errorf("application run finished with error: %w", err)
return fmt.Errorf("collector server run finished with error: %w", err)
}

return nil
Expand Down
2 changes: 1 addition & 1 deletion cmd/otelcol/main_others.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ package main

import "go.opentelemetry.io/collector/service"

func run(settings service.AppSettings) error {
func run(settings service.ColSettings) error {
return runInteractive(settings)
}
4 changes: 2 additions & 2 deletions cmd/otelcol/main_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
"go.opentelemetry.io/collector/service"
)

func run(set service.AppSettings) error {
func run(set service.ColSettings) error {
if useInteractiveMode, err := checkUseInteractiveMode(); err != nil {
return err
} else if useInteractiveMode {
Expand All @@ -51,7 +51,7 @@ func checkUseInteractiveMode() (bool, error) {
}
}

func runService(set service.AppSettings) error {
func runService(set service.ColSettings) error {
// do not need to supply service name when startup is invoked through Service Control Manager directly
if err := svc.Run("", service.NewWindowsService(set)); err != nil {
return fmt.Errorf("failed to start service %w", err)
Expand Down
2 changes: 1 addition & 1 deletion component/host.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
)

// Host represents the entity that is hosting a Component. It is used to allow communication
// between the Component and its host (normally the service.Service is the host).
// between the Component and its host (normally the service.Collector is the host).
type Host interface {
// ReportFatalError is used to report to the host that the component
// encountered a fatal error (i.e.: an error that the instance can't recover
Expand Down
2 changes: 1 addition & 1 deletion docs/service-extensions.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ to receive data. These are a necessary addition to allow implementing extensions
that indicate to LBs and external systems if the service instance is ready or
not to receive data
(e.g.: a [k8s readiness probe](https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/#define-readiness-probes)).
These state changes are under the control of the service application hosting
These state changes are under the control of the service server hosting
the extensions.

There are more complex scenarios in which there can be notifications of state
Expand Down
Loading