Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently kafkareceiver doesn't support metrics type. This PR adds metrics support to it (almost a direct copy/substitute from traces/logs implementation).
Testing:
go test ./...
: under kafkareceiver folder, all passmake test
: some cases failed locally but should be unrelatedCaveats:
If same config is used between traces/metrics/logs, it will errors about:
The error message says
traces
andmetrics
, but this would actually also error when used againsttraces
andlogs
. Because of this currently this receiver needs multiple kafka configs (and should use different topics) to use in traces/metrics/logs.I thought about merging traces/metrics/logs into one
receiver
. However in that case we need separatedtopic
config to differentiate between different data types, otherwise the receiver has no way to tell the type of the message its consuming without trial and error, which would be inefficient. This PR can be seen as a starting point of that and just enables using metrics in kafkareceiver.