Remove internal rep deprecated funcs #5018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually we wait 2 cycles for pdata deprecated fields, but this is internal only, so can be removed faster. Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
rminternalrep
branch
from
9663815 to
95cfdbc
Compare
Codecov Report
@@ Coverage Diff @@
## main #5018 +/- ##
==========================================
+ Coverage 90.96% 91.06% +0.10%
==========================================
Files 183 180 -3
Lines 10692 10680 -12
==========================================
Hits 9726 9726
+ Misses 749 737 -12
Partials 217 217
Continue to review full report at Codecov.
|
codeboten
approved these changes
Mar 17, 2022
dmitryax
approved these changes
Mar 17, 2022
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
Usually we wait 2 cycles for pdata deprecated fields, but this is internal only, so can be removed faster. Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually we wait 2 cycles for pdata deprecated fields, but this is internal only, so can be removed faster.
Fixes #4706
Signed-off-by: Bogdan Drutu [email protected]