Move MapProvider to config, split providers in separate packages #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
mvmapprovider
branch
2 times, most recently
from
2337822 to
b11df60
Compare
Codecov Report
@@ Coverage Diff @@
## main #5030 +/- ##
==========================================
- Coverage 91.07% 91.04% -0.03%
==========================================
Files 180 180
Lines 10810 10810
==========================================
- Hits 9845 9842 -3
- Misses 747 749 +2
- Partials 218 219 +1
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
mvmapprovider
branch
3 times, most recently
from
63e0715 to
141bd61
Compare
jpkrohling
reviewed
Mar 17, 2022
bogdandrutu
changed the title
bogdandrutu
force-pushed
the
mvmapprovider
branch
2 times, most recently
from
15accac to
f2cc310
Compare
This PR: 1. moves the `configmapprovider.Provider` to `config.MapProvider` and related structs. 2. every provider (env, file, yaml) are split in their own packages to help open-telemetry#4759. Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
mvmapprovider
branch
from
f2cc310 to
f49a8b4
Compare
mx-psi
approved these changes
Mar 22, 2022
tigrannajaryan
approved these changes
Mar 22, 2022
Aneurysm9
approved these changes
Mar 22, 2022
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
…n-telemetry#5030) This PR: 1. moves the `configmapprovider.Provider` to `config.MapProvider` and related structs. 2. every provider (env, file, yaml) are split in their own packages to help open-telemetry#4759. Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
configmapprovider.Providertoconfig.MapProviderand related structs.Signed-off-by: Bogdan Drutu [email protected]