Deprecate featureflags.FlagValue.SetSlice, unnecessary public #5053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
depsetslice
branch
from
642f86d to
3dad450
Compare
Codecov Report
@@ Coverage Diff @@
## main #5053 +/- ##
=======================================
Coverage 91.07% 91.07%
=======================================
Files 180 180
Lines 10808 10810 +2
=======================================
+ Hits 9843 9845 +2
Misses 747 747
Partials 218 218
Continue to review full report at Codecov.
|
jpkrohling
reviewed
Mar 21, 2022
jpkrohling
approved these changes
Mar 21, 2022
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
…elemetry#5053) * Deprecate featureflags.FlagValue.SetSlice, unnecessary public Signed-off-by: Bogdan Drutu <[email protected]> * Add back SetSlice tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu [email protected]