Deprecate global flag in featuregates #5060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
commented
Mar 22, 2022
| @@ -88,6 +90,7 @@ func (s *WindowsService) start(elog *eventlog.Log, colErrorChannel chan error) e | |||
| if err := flags().Parse(os.Args[1:]); err != nil { | |||
| return err | |||
| } | |||
| featuregate.Apply(gatesList) | |||
There was a problem hiding this comment.
This PR also fixes the use of featuregates on windows, where the gate flag was not applied.
bogdandrutu
force-pushed
the
deprecateglobalflag
branch
from
af0f971 to
37b854b
Compare
Codecov Report
@@ Coverage Diff @@
## main #5060 +/- ##
==========================================
+ Coverage 91.03% 91.07% +0.04%
==========================================
Files 180 180
Lines 10810 10814 +4
==========================================
+ Hits 9841 9849 +8
+ Misses 750 747 -3
+ Partials 219 218 -1
Continue to review full report at Codecov.
|
Distributions that build without the builder will need to declare it as they do for "config" and "set". Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
deprecateglobalflag
branch
from
37b854b to
580c271
Compare
dmitryax
approved these changes
Mar 23, 2022
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
Distributions that build without the builder will need to declare it as they do for "config" and "set". Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distributions that build without the builder will need to declare it as they do for "config" and "set".
Signed-off-by: Bogdan Drutu [email protected]