Deprecate last funcs/structs in componenthelper
#5069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5069 +/- ##
==========================================
- Coverage 89.51% 89.50% -0.01%
==========================================
Files 183 183
Lines 11040 11041 +1
==========================================
Hits 9882 9882
- Misses 936 937 +1
Partials 222 222
Continue to review full report at Codecov.
|
Fixes open-telemetry#4681 These funcs/structs are not used, and in case we need them in multiple places we can add them to `component` directly. Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
rmcomphelper
branch
from
435009f to
183f72d
Compare
bogdandrutu
changed the title
componenthelper.componenthelper
dmitryax
approved these changes
Mar 25, 2022
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
Fixes open-telemetry#4681 These funcs/structs are not used, and in case we need them in multiple places we can add them to `component` directly. Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4681
These funcs/structs are not used, and in case we need them in multiple places we can add them to
componentdirectly.Signed-off-by: Bogdan Drutu [email protected]