[component] Change component.Type underlying type to a struct #9472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
force-pushed
the
mx-psi/switch-to-type
branch
from
d102e76 to
51cf15b
Compare
mx-psi
commented
Feb 6, 2024
| @@ -155,14 +157,18 @@ func MustNewType(strType string) Type { | |||
| // collecting metrics, traces and logs, this can expand in the future. | |||
| type DataType = Type | |||
There was a problem hiding this comment.
I am keeping this for now, but we can revisit once we tackle #9429
There was a problem hiding this comment.
(The alternative is to change this to type DataType string)
There was a problem hiding this comment.
It is an alias to Type because we use component.ID (which is not generic) for the pipeline.ID. Because of that we made this equal with Type.
mx-psi
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Feb 6, 2024
**Description:** Replaces usages of `component.Type(..)` by `component.MustNewType` **Link to tracking Issue:** Needed for open-telemetry/opentelemetry-collector/pull/9472
mx-psi
force-pushed
the
mx-psi/switch-to-type
branch
from
25ae139 to
da47a2d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9472 +/- ##
==========================================
- Coverage 90.62% 90.60% -0.02%
==========================================
Files 347 347
Lines 18238 18240 +2
==========================================
- Hits 16528 16527 -1
- Misses 1381 1383 +2
- Partials 329 330 +1 ☔ View full report in Codecov by Sentry. |
mx-psi
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Feb 6, 2024
…1075) **Description:** Another PR needed for open-telemetry/opentelemetry-collector/pull/9472
mx-psi
added
needed-for-1.0
release:required-for-ga
mx-psi
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Feb 8, 2024
…ame` when passing literal strings (#31125) **Description:** Runs the following commands: - `rg "component.NewID\(\".*?\"\)" -l | xargs sd 'component.NewID\((".*?")\)' 'component.MustNewID($1)'` - `rg "component.NewIDWithName\(\".*?\"" -l | xargs sd 'component.NewIDWithName\((".*?")' 'component. MustNewIDWithName($1'` Additionally, makes some manual fixes Needed for open-telemetry/opentelemetry-collector/pull/9472 **Link to tracking Issue:** open-telemetry/opentelemetry-collector/issues/9208
mx-psi
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Feb 8, 2024
**Description:** More changes in tests for open-telemetry/opentelemetry-collector/pull/9472 **Link to tracking Issue:** open-telemetry/opentelemetry-collector/pull/9208
mx-psi
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Feb 8, 2024
**Description**: Some more changes in tests for open-telemetry/opentelemetry-collector/pull/9472 **Link to tracking Issue**: open-telemetry/opentelemetry-collector/issues/9208
|
I think open-telemetry/opentelemetry-collector-contrib/pull/31263 should fix the remaining issues with contrib tests |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
mx-psi
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Mar 4, 2024
**Description:** Needed for open-telemetry/opentelemetry-collector/pull/9472
|
cc @open-telemetry/collector-approvers this is ready to review, but I won't merge this for v0.96.0, will wait until after the release |
jpkrohling
approved these changes
Mar 6, 2024
mx-psi
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Mar 6, 2024
**Description:** Include open-telemetry/opentelemetry-collector/pull/9472 --------- Signed-off-by: Pablo Baeyens <[email protected]>
samiura
pushed a commit
to samiura/opentelemetry-collector-contrib
that referenced
this pull request
Mar 8, 2024
**Description:** Include open-telemetry/opentelemetry-collector/pull/9472 --------- Signed-off-by: Pablo Baeyens <[email protected]>
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
**Description:** Needed for open-telemetry/opentelemetry-collector/pull/9472
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
**Description:** Include open-telemetry/opentelemetry-collector/pull/9472 --------- Signed-off-by: Pablo Baeyens <[email protected]>
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
**Description:** Needed for open-telemetry/opentelemetry-collector/pull/9472
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
**Description:** Include open-telemetry/opentelemetry-collector/pull/9472 --------- Signed-off-by: Pablo Baeyens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Follow up to #9414 and open-telemetry/opentelemetry-collector-contrib/pull/31038.
Link to tracking Issue: Fixes #9208.