(configgrpc): configure memorylimiterextension when setting up grpc servers #9673
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9673 +/- ##
==========================================
- Coverage 90.93% 90.93% -0.01%
==========================================
Files 347 348 +1
Lines 18346 18408 +62
==========================================
+ Hits 16683 16739 +56
- Misses 1340 1346 +6
Partials 323 323 ☔ View full report in Codecov by Sentry. |
moh-osman3
force-pushed
the
mohosman/configgrpc-support-memorylimiter-extension
branch
from
8752b44 to
95c8707
Compare
moh-osman3
force-pushed
the
mohosman/configgrpc-support-memorylimiter-extension
branch
from
34b51ea to
bde885b
Compare
| return memoryLimiterUnaryServerInterceptor(ctx, req, info, handler, memoryLimiter) | ||
| }) | ||
| sInterceptors = append(sInterceptors, func(srv any, ss grpc.ServerStream, info *grpc.StreamServerInfo, handler grpc.StreamHandler) error { | ||
| return memoryLimiterStreamServerInterceptor(srv, ss, info, handler, memoryLimiter) |
There was a problem hiding this comment.
This path would require setting up streaming server/client to increase unit test coverage. This doesn't seem necessary because I already have coverage for memoryLimiterStreamServerInterceptor.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description:
This PR adds a new configgrpc option to configure a memory limiter extension to use. This allows users to leverage the new memorylimiterextension within receivers that set up a gRPC server.
Link to tracking Issue:
This is part of #9591 and relates to #8632
Testing:
Added new unit tests that cover the added code.