Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update existing maintaining dependencies doc #3195

Merged
merged 9 commits into from
Dec 11, 2024

Conversation

zurex
Copy link
Contributor

@zurex zurex commented Dec 9, 2024

Fixes

This is the first in a series of fixes for this issue #2678 .

Changes

  • Add section how to update git submodule
  • Add section how to update bazel dependency
  • Remove similar part in existing part.

@zurex zurex requested a review from a team as a code owner December 9, 2024 13:04
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 3d0aa23
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/675997f4e5c8590008fb6f69

@zurex
Copy link
Contributor Author

zurex commented Dec 10, 2024

@marcalff would you mind take a look and help me to review this?

@marcalff
Copy link
Member

Thanks for looking at the doc.

Please fix various CI failures (format, spelling, markdown).

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.83%. Comparing base (6d87bd6) to head (3d0aa23).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3195   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files         195      195           
  Lines        6154     6154           
=======================================
  Hits         5405     5405           
  Misses        749      749           

@marcalff marcalff changed the title Update existing maintaining doc [DOC] Update existing maintaining doc Dec 11, 2024
@marcalff marcalff changed the title [DOC] Update existing maintaining doc [DOC] Update existing maintaining dependencies doc Dec 11, 2024
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup.

@marcalff marcalff merged commit 490f882 into open-telemetry:main Dec 11, 2024
57 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Dec 11, 2024
[DOC] Update existing maintaining dependencies doc (open-telemetry#3195)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants