Skip to content

Commit

Permalink
remove url.path because it is now set from HttpTelemetryModule
Browse files Browse the repository at this point in the history
  • Loading branch information
Wraith2 committed Jun 13, 2024
1 parent 0d797a6 commit 39ccd68
Showing 1 changed file with 0 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ private void OnStartActivity(Activity activity, HttpContext context)
}

var request = context.Request;
var requestValues = request.Unvalidated;

// see the spec https://github.com/open-telemetry/semantic-conventions/blob/v1.24.0/docs/http/http-spans.md
var originalHttpMethod = request.HttpMethod;
Expand All @@ -84,8 +83,6 @@ private void OnStartActivity(Activity activity, HttpContext context)
activity.SetTag(SemanticConventions.AttributeNetworkProtocolVersion, protocolVersion);
}

activity.SetTag(SemanticConventions.AttributeUrlPath, requestValues.Path);

// TODO url.query should be sanitized
var query = url.Query;
if (!string.IsNullOrEmpty(query))
Expand Down

0 comments on commit 39ccd68

Please sign in to comment.