Code review.

open-telemetry · Aug 5, 2024 · 417835b · 417835b
1 parent fa6d187
commit 417835b
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/ActivityHelper.cs b/src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/ActivityHelper.cs
@@ -63,18 +63,17 @@ public static bool HasStarted(HttpContext context, out Activity? aspNetActivity)
     {
         PropagationContext propagationContext = textMapPropagator.Extract(default, context.Request, HttpRequestHeaderValuesGetter);
 
-        KeyValuePair<string, object?>[]? tags = null;
+        KeyValuePair<string, object?>[]? tags;
         if (context.Request?.Unvalidated?.Path is string path)
         {
-            tags = cachedTagsStorage;
-            if (tags is null)
-            {
-                tags = new KeyValuePair<string, object?>[1];
-                cachedTagsStorage = tags;
-            }
+            tags = cachedTagsStorage ??= new KeyValuePair<string, object?>[1];
 
             tags[0] = new KeyValuePair<string, object?>("url.path", path);
         }
+        else
+        {
+            tags = null;
+        }
 
         Activity? activity = AspNetSource.StartActivity(TelemetryHttpModule.AspNetActivityName, ActivityKind.Server, propagationContext.ActivityContext, tags);