[ResourceDetectors.Azure] Azure Container Apps Resource Detector #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
Feb 3, 2024
| attributeList.Add(new KeyValuePair<string, object>(kvp.Key, attributeValue)); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
lets add a internal log, saying "ACADetector bailed out due to lack of env variable confirming this to be an ACA"/similar.
There was a problem hiding this comment.
This has to be done for all the detectors; I will do this as a follow-up task.
test/OpenTelemetry.ResourceDetectors.Azure.Tests/AzureResourceDetectorTests.cs
Outdated
Show resolved
Hide resolved
vishweshbankwar
approved these changes
Feb 3, 2024
Kielek
added
the
comp:resources.azure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please provide a brief description of the changes here.
A new Azure Container App Resource Detector, which maps specific Azure Container Apps environment variables to corresponding OpenTelemetry resource attributes.
CONTAINER_APP_NAMEservice.nameCONTAINER_APP_REVISIONservice.versionCONTAINER_APP_REPLICA_NAMEservice.instance.idTODO
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes