Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AspNet] Rename options class to AspNetTraceInstrumentationOptions #1604

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Mar 7, 2024

Propagate changes from open-telemetry/opentelemetry-dotnet#5285

Changes

[Instrumentation.AspNet] Rename options class to AspNetTraceInstrumentationOptions

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.37%. Comparing base (71655ce) to head (3b3ef63).
Report is 159 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1604      +/-   ##
==========================================
+ Coverage   73.91%   75.37%   +1.45%     
==========================================
  Files         267       15     -252     
  Lines        9615      333    -9282     
==========================================
- Hits         7107      251    -6856     
+ Misses       2508       82    -2426     
Flag Coverage Δ
unittests-Instrumentation.AspNet 75.37% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ry.Instrumentation.AspNet/AspNetInstrumentation.cs 100.00% <100.00%> (ø)
...tation.AspNet/AspNetTraceInstrumentationOptions.cs 100.00% <ø> (ø)
...umentation.AspNet/Implementation/HttpInListener.cs 86.76% <100.00%> (-1.55%) ⬇️
...entation.AspNet/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)

... and 262 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review March 7, 2024 09:58
@Kielek Kielek requested a review from a team March 7, 2024 09:58
@Kielek Kielek added the comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet label Mar 7, 2024
@Kielek Kielek force-pushed the aspnet-rename-options-class branch from b69da12 to 3b3ef63 Compare March 7, 2024 11:25
@Kielek Kielek merged commit 78d075c into open-telemetry:main Mar 7, 2024
26 checks passed
@Kielek Kielek deleted the aspnet-rename-options-class branch March 7, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants