Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResourceDetector.Process] support process.owner attribute #1608

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Mar 12, 2024

Towards: #1515

Changes

[ResourceDetector.Process] support process.owner attribute

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

@Kielek Kielek added the comp:resources.process Things related to OpenTelemetry.Resources.Process label Mar 12, 2024
@github-actions github-actions bot requested a review from lachmatt March 12, 2024 07:47
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (71655ce) to head (ba4f60e).
Report is 161 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             main     #1608       +/-   ##
============================================
+ Coverage   73.91%   100.00%   +26.08%     
============================================
  Files         267         3      -264     
  Lines        9615        64     -9551     
============================================
- Hits         7107        64     -7043     
+ Misses       2508         0     -2508     
Flag Coverage Δ
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-ResourceDetectors.Process 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...metry.ResourceDetectors.Process/ProcessDetector.cs 100.00% <100.00%> (ø)

... and 262 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review March 12, 2024 07:54
@Kielek Kielek requested a review from a team March 12, 2024 07:54
@Kielek Kielek merged commit 609565c into open-telemetry:main Mar 12, 2024
39 checks passed
@Kielek Kielek deleted the rd-process-owner branch March 12, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.process Things related to OpenTelemetry.Resources.Process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants