Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AWSLambda] Replace .NET 6 target with .NET 8 and add .NET Standard 2.0 #2140

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

joegoldman2
Copy link
Contributor

@joegoldman2 joegoldman2 commented Oct 3, 2024

Changes

Replace .NET 6 target, which will be very soon out of support, with .NET 8 and add support for .NET Standard 2.0.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@joegoldman2 joegoldman2 requested a review from a team as a code owner October 3, 2024 07:15
@github-actions github-actions bot added the comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.78%. Comparing base (71655ce) to head (c9983c2).
Report is 481 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2140       +/-   ##
===========================================
+ Coverage   73.91%   84.78%   +10.86%     
===========================================
  Files         267       20      -247     
  Lines        9615      368     -9247     
===========================================
- Hits         7107      312     -6795     
+ Misses       2508       56     -2452     
Flag Coverage Δ
unittests-Instrumentation.AWS 84.78% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 274 files with indirect coverage changes

@Oberon00
Copy link
Member

Oberon00 commented Oct 3, 2024

I would prefer waiting at least for the "Block function create" date (Feb 28, 2025) https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html

image

@joegoldman2
Copy link
Contributor Author

I would prefer waiting at least for the "Block function create" date (Feb 28, 2025) https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html

The addition of .NET Standard 2.0 target should be fine for people who are targeting .NET 6 and less.

@joegoldman2 joegoldman2 changed the title [Instrumentation.AWSLambda] Replace .NET 6 target with .NET 8 [Instrumentation.AWSLambda] Replace .NET 6 target with .NET 8 and add .NET Standard 2.0 Oct 3, 2024
@Oberon00
Copy link
Member

Oberon00 commented Oct 3, 2024

That looks fine to me. Do we even need .NET 8 separately if we have netstandard2.0 as target?

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit be8f01b into open-telemetry:main Oct 3, 2024
59 checks passed
@joegoldman2 joegoldman2 deleted the awslambda-tfm branch October 3, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants