-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.AWSLambda] Replace .NET 6 target with .NET 8 and add .NET Standard 2.0 #2140
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2140 +/- ##
===========================================
+ Coverage 73.91% 84.78% +10.86%
===========================================
Files 267 20 -247
Lines 9615 368 -9247
===========================================
- Hits 7107 312 -6795
+ Misses 2508 56 -2452
Flags with carried forward coverage won't be shown. Click here to find out more. |
I would prefer waiting at least for the "Block function create" date (Feb 28, 2025) https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html |
The addition of .NET Standard 2.0 target should be fine for people who are targeting .NET 6 and less. |
That looks fine to me. Do we even need .NET 8 separately if we have netstandard2.0 as target? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
Replace .NET 6 target, which will be very soon out of support, with .NET 8 and add support for .NET Standard 2.0.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes