Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.SqlClient] Remove .NET 6 target #2159

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

joegoldman2
Copy link
Contributor

Changes

Remove .NET 6 target which will be very soon out of support.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@joegoldman2 joegoldman2 requested a review from a team as a code owner October 4, 2024 08:03
@github-actions github-actions bot added the comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient label Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.55%. Comparing base (71655ce) to head (66441c0).
Report is 492 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2159       +/-   ##
===========================================
+ Coverage   73.91%   90.55%   +16.64%     
===========================================
  Files         267        7      -260     
  Lines        9615      286     -9329     
===========================================
- Hits         7107      259     -6848     
+ Misses       2508       27     -2481     
Flag Coverage Δ
unittests-Instrumentation.SqlClient 90.55% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 271 files with indirect coverage changes

@Kielek Kielek merged commit 0b01daa into open-telemetry:main Oct 4, 2024
59 checks passed
@joegoldman2 joegoldman2 deleted the sqlclient-tfm branch October 4, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants