Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.Runtime] Remove legacy checks that only applied for .NET 6 #2325

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

xiang17
Copy link
Contributor

@xiang17 xiang17 commented Nov 14, 2024

Fixes #
Design discussion issue #

Changes

Removed checks that was only needed when .NET 6 was supported

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions bot requested a review from twenzel November 14, 2024 22:48
@github-actions github-actions bot added the comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime label Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (71655ce) to head (a3938cc).
Report is 610 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             main     #2325       +/-   ##
============================================
+ Coverage   73.91%   100.00%   +26.08%     
============================================
  Files         267         2      -265     
  Lines        9615       142     -9473     
============================================
- Hits         7107       142     -6965     
+ Misses       2508         0     -2508     
Flag Coverage Δ
unittests-Instrumentation.Runtime 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...elemetry.Instrumentation.Runtime/RuntimeMetrics.cs 100.00% <100.00%> (ø)

... and 263 files with indirect coverage changes

---- 🚨 Try these New Features:

@xiang17 xiang17 marked this pull request as ready for review November 14, 2024 22:57
@xiang17 xiang17 requested a review from a team as a code owner November 14, 2024 22:57
@Kielek Kielek merged commit a0c764e into open-telemetry:main Nov 21, 2024
60 checks passed
@xiang17 xiang17 deleted the xiang17/RuntimeNet7ChecksRemoval branch November 27, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants