-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Prepare to .NET9 - reenable analysis level #2350
Open
Kielek
wants to merge
25
commits into
open-telemetry:main
Choose a base branch
from
Kielek:net9prep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+195
−284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
long todo comments
it was not using disposing attribute, ref https://learn.microsoft.com/en-us/dotnet/standard/garbage-collection/implementing-dispose
github-actions
bot
requested review from
cijothomas,
CodeBlanch,
fred2u,
matt-hensley,
MikeGoldsmith and
muhammad-othman
November 28, 2024 08:57
github-actions
bot
added
comp:instrumentation.cassandra
Things related to OpenTelemetry.Instrumentation.Cassandra
comp:instrumentation.entityframeworkcore
Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore
comp:instrumentation.http
Things related to OpenTelemetry.Instrumentation.Http
comp:instrumentation.process
Things related to OpenTelemetry.Instrumentation.Process
comp:instrumentation.sqlclient
Things related to OpenTelemetry.Instrumentation.SqlClient
comp:instrumentation.wcf
Things related to OpenTelemetry.Instrumentation.Wcf
comp:sampler.aws
Things related to OpenTelemetry.Samplers.AWS
perf
Performance related
comp:exporter.geneva
Things related to OpenTelemetry.Exporter.Geneva
comp:exporter.instana
Things related to OpenTelemetry.Instrumentation.Instana
comp:exporter.stackdriver
Things related to OpenTelemetry.Exporter.Stackdriver
comp:extensions.aws
Things related to OpenTelemetry.Extensions.AWS
comp:instrumentation.aws
Things related to OpenTelemetry.Instrumentation.AWS
comp:instrumentation.aspnetcore
Things related to OpenTelemetry.Instrumentation.AspNetCore
comp:instrumentation.hangfire
Things related to OpenTelemetry.Instrumentation.Hangfire
comp:instrumentation.stackexchangeredis
Things related to OpenTelemetry.Instrumentation.StackExchangeRedis
comp:persistentstorage.filesystem
Things related to OpenTelemetry.PersistentStorage.FileSystem
comp:resources.aws
Things related to OpenTelemetry.Resources.AWS
comp:resources.operatingsystem
Things related to OpenTelemetry.Resources.OperatingSystem
labels
Nov 28, 2024
github-actions
bot
added
the
comp:exporter.onecollector
Things related to OpenTelemetry.Exporter.OneCollector
label
Nov 28, 2024
RassK
approved these changes
Nov 28, 2024
fred2u
approved these changes
Nov 29, 2024
xsoheilalizadeh
approved these changes
Nov 29, 2024
ppittle
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp:exporter.geneva
Things related to OpenTelemetry.Exporter.Geneva
comp:exporter.instana
Things related to OpenTelemetry.Instrumentation.Instana
comp:exporter.onecollector
Things related to OpenTelemetry.Exporter.OneCollector
comp:exporter.stackdriver
Things related to OpenTelemetry.Exporter.Stackdriver
comp:extensions.aws
Things related to OpenTelemetry.Extensions.AWS
comp:extensions
Things related to OpenTelemetry.Extensions
comp:instrumentation.aspnet
Things related to OpenTelemetry.Instrumentation.AspNet
comp:instrumentation.aspnetcore
Things related to OpenTelemetry.Instrumentation.AspNetCore
comp:instrumentation.aws
Things related to OpenTelemetry.Instrumentation.AWS
comp:instrumentation.cassandra
Things related to OpenTelemetry.Instrumentation.Cassandra
comp:instrumentation.entityframeworkcore
Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore
comp:instrumentation.hangfire
Things related to OpenTelemetry.Instrumentation.Hangfire
comp:instrumentation.http
Things related to OpenTelemetry.Instrumentation.Http
comp:instrumentation.process
Things related to OpenTelemetry.Instrumentation.Process
comp:instrumentation.sqlclient
Things related to OpenTelemetry.Instrumentation.SqlClient
comp:instrumentation.stackexchangeredis
Things related to OpenTelemetry.Instrumentation.StackExchangeRedis
comp:instrumentation.wcf
Things related to OpenTelemetry.Instrumentation.Wcf
comp:persistentstorage.filesystem
Things related to OpenTelemetry.PersistentStorage.FileSystem
comp:resources.aws
Things related to OpenTelemetry.Resources.AWS
comp:resources.operatingsystem
Things related to OpenTelemetry.Resources.OperatingSystem
comp:sampler.aws
Things related to OpenTelemetry.Samplers.AWS
documentation
Improvements or additions to documentation
infra
Infra work - CI/CD, code coverage, linters
perf
Performance related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow up #2251
All leftovers. Enables
<AnalysisLevel>latest-all</AnalysisLevel>
PR is a bit bigger than usual, but I would like to finish finally this effort. It should be safe to review commits independently.
Most important commits:
Merge requirement checklist
[ ] Unit tests added/updated[ ] AppropriateCHANGELOG.md
files updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)