Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Prepare to .NET9 - reenable analysis level #2350

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Nov 28, 2024

Changes

Follow up #2251

All leftovers. Enables <AnalysisLevel>latest-all</AnalysisLevel>

PR is a bit bigger than usual, but I would like to finish finally this effort. It should be safe to review commits independently.
Most important commits:

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions bot added comp:instrumentation.cassandra Things related to OpenTelemetry.Instrumentation.Cassandra comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS perf Performance related comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:exporter.instana Things related to OpenTelemetry.Instrumentation.Instana comp:exporter.stackdriver Things related to OpenTelemetry.Exporter.Stackdriver comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore comp:instrumentation.hangfire Things related to OpenTelemetry.Instrumentation.Hangfire comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis comp:persistentstorage.filesystem Things related to OpenTelemetry.PersistentStorage.FileSystem comp:resources.aws Things related to OpenTelemetry.Resources.AWS comp:resources.operatingsystem Things related to OpenTelemetry.Resources.OperatingSystem labels Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.82%. Comparing base (71655ce) to head (e1b3c61).
Report is 618 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2350      +/-   ##
==========================================
- Coverage   73.91%   67.82%   -6.10%     
==========================================
  Files         267      363      +96     
  Lines        9615    13394    +3779     
==========================================
+ Hits         7107     9084    +1977     
- Misses       2508     4310    +1802     
Flag Coverage Δ
unittests-Contrib.Shared.Tests 84.04% <100.00%> (?)
unittests-Exporter.Geneva 47.44% <100.00%> (?)
unittests-Exporter.InfluxDB 95.14% <ø> (?)
unittests-Exporter.Instana 74.86% <ø> (?)
unittests-Exporter.OneCollector 94.57% <ø> (?)
unittests-Exporter.Stackdriver 79.26% <ø> (?)
unittests-Extensions 88.63% <100.00%> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 84.55% <100.00%> (?)
unittests-Instrumentation.AspNet 77.00% <100.00%> (?)
unittests-Instrumentation.AspNetCore 70.33% <ø> (?)
unittests-Instrumentation.ConfluentKafka 14.37% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 80.12% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 57.06% <100.00%> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcCore 91.42% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 62.18% <100.00%> (?)
unittests-Instrumentation.Owin 88.12% <ø> (?)
unittests-Instrumentation.Process 100.00% <100.00%> (?)
unittests-Instrumentation.Quartz 78.76% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 91.69% <100.00%> (?)
unittests-Instrumentation.StackExchangeRedis 68.26% <ø> (?)
unittests-Instrumentation.Wcf 49.55% <100.00%> (?)
unittests-PersistentStorage 65.21% <ø> (?)
unittests-Resources.AWS 79.16% <ø> (?)
unittests-Resources.Azure 84.56% <ø> (?)
unittests-Resources.Container 67.34% <ø> (?)
unittests-Resources.Gcp 71.15% <ø> (?)
unittests-Resources.Host 73.91% <ø> (?)
unittests-Resources.OperatingSystem 75.40% <ø> (?)
unittests-Resources.Process 100.00% <ø> (?)
unittests-Resources.ProcessRuntime 78.26% <ø> (?)
unittests-Sampler.AWS 88.12% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rter.Geneva/Metrics/GenevaMetricExporterOptions.cs 100.00% <100.00%> (ø)
...ons/Internal/ActivityEventAttachingLogProcessor.cs 88.23% <100.00%> (-5.89%) ⬇️
...ry.Extensions/Internal/DefaultLogStateConverter.cs 87.50% <100.00%> (ø)
...c/OpenTelemetry.Extensions/Internal/RateLimiter.cs 100.00% <100.00%> (ø)
...nTelemetry.Extensions/Trace/RateLimitingSampler.cs 100.00% <100.00%> (ø)
...AWS/Implementation/AWSTracingPipelineCustomizer.cs 90.90% <100.00%> (+3.40%) ⬆️
...on.AspNet/Implementation/HttpRequestRouteHelper.cs 100.00% <100.00%> (ø)
...mplementation/EntityFrameworkDiagnosticListener.cs 53.03% <100.00%> (+0.64%) ⬆️
...tp/Implementation/HttpHandlerDiagnosticListener.cs 72.95% <100.00%> (ø)
...entation.Process/MeterProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
... and 8 more

... and 369 files with indirect coverage changes

@github-actions github-actions bot added the comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector label Nov 28, 2024
@Kielek Kielek marked this pull request as ready for review November 28, 2024 09:38
@Kielek Kielek requested a review from a team as a code owner November 28, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:exporter.instana Things related to OpenTelemetry.Instrumentation.Instana comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector comp:exporter.stackdriver Things related to OpenTelemetry.Exporter.Stackdriver comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS comp:extensions Things related to OpenTelemetry.Extensions comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS comp:instrumentation.cassandra Things related to OpenTelemetry.Instrumentation.Cassandra comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore comp:instrumentation.hangfire Things related to OpenTelemetry.Instrumentation.Hangfire comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf comp:persistentstorage.filesystem Things related to OpenTelemetry.PersistentStorage.FileSystem comp:resources.aws Things related to OpenTelemetry.Resources.AWS comp:resources.operatingsystem Things related to OpenTelemetry.Resources.OperatingSystem comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS documentation Improvements or additions to documentation infra Infra work - CI/CD, code coverage, linters perf Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants