Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.Runtime] Update instrument type for monotonically increasing metrics #476

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

xiang17
Copy link
Contributor

@xiang17 xiang17 commented Jun 30, 2022

Changes

Update instrument type for monitor.lock_contention.count and thread_pool.completed_items.count to ObservableCounter

For significant contributions please make sure you have completed the following items:

@xiang17 xiang17 requested a review from a team June 30, 2022 00:16
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #476 (3bbb900) into main (270c33d) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #476   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        162     162           
  Lines       4979    4979           
=====================================
  Misses      4979    4979           
Impacted Files Coverage Δ
...elemetry.Instrumentation.Runtime/RuntimeMetrics.cs 0.00% <0.00%> (ø)

@utpilla utpilla merged commit 023f6b2 into open-telemetry:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants