Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.Process] Added 2 instruments: CPU Utilization and threads #687

Merged
merged 15 commits into from
Oct 14, 2022

Conversation

Yun-Ting
Copy link
Contributor

@Yun-Ting Yun-Ting commented Oct 12, 2022

Working towards: #447
Background: #335
Following OTel spec.

The initial value of collectionTimeStamp is defined as DateTime.UtcNow.
And the elapsed time is measured as the time difference between the last collection of the reader, which triggered the callback function and the current collection.

@Yun-Ting Yun-Ting marked this pull request as ready for review October 12, 2022 21:05
@Yun-Ting Yun-Ting requested a review from a team October 12, 2022 21:05
@utpilla utpilla added the comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process label Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #687 (d25e0b7) into main (a0aa56c) will increase coverage by 0.19%.
The diff coverage is 100.00%.

❗ Current head d25e0b7 differs from pull request most recent head 5320c82. Consider uploading reports for the commit 5320c82 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #687      +/-   ##
==========================================
+ Coverage   77.69%   77.88%   +0.19%     
==========================================
  Files         175      175              
  Lines        5249     5295      +46     
==========================================
+ Hits         4078     4124      +46     
  Misses       1171     1171              
Impacted Files Coverage Δ
...elemetry.Instrumentation.Process/ProcessMetrics.cs 100.00% <100.00%> (ø)

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utpilla utpilla merged commit eeca089 into open-telemetry:main Oct 14, 2022
@Yun-Ting Yun-Ting deleted the yunl/PI branch October 17, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants