-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.Process] Added 2 instruments: CPU Utilization and threads #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
added
the
comp:instrumentation.process
Things related to OpenTelemetry.Instrumentation.Process
label
Oct 12, 2022
utpilla
reviewed
Oct 12, 2022
utpilla
reviewed
Oct 12, 2022
utpilla
reviewed
Oct 12, 2022
utpilla
reviewed
Oct 12, 2022
CodeBlanch
reviewed
Oct 13, 2022
CodeBlanch
reviewed
Oct 13, 2022
utpilla
reviewed
Oct 13, 2022
utpilla
reviewed
Oct 13, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
==========================================
+ Coverage 77.69% 77.88% +0.19%
==========================================
Files 175 175
Lines 5249 5295 +46
==========================================
+ Hits 4078 4124 +46
Misses 1171 1171
|
CodeBlanch
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2 tasks
utpilla
reviewed
Oct 14, 2022
utpilla
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards: #447
Background: #335
Following OTel spec.
The initial value of collectionTimeStamp is defined as
DateTime.UtcNow
.And the elapsed time is measured as the time difference between the last collection of the reader, which triggered the callback function and the current collection.