Make ZipkinExporter and JaegerExporter internal #1540
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1528 I made the OtlpExporter internal. This does the same for the Zipkin and Jaeger exporters.
The thought is that adding and configuring these exporters is to be done through their respective
TracerProviderBuilder
extension methods. I also believe there is a plan to apply the pattern started with Zipkin in #1504 to both Jaeger and Otlp for configuring Simple vs. Batch export.