Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ZipkinExporter and JaegerExporter internal #1540

Merged

Conversation

alanwest
Copy link
Member

In #1528 I made the OtlpExporter internal. This does the same for the Zipkin and Jaeger exporters.

The thought is that adding and configuring these exporters is to be done through their respective TracerProviderBuilder extension methods. I also believe there is a plan to apply the pattern started with Zipkin in #1504 to both Jaeger and Otlp for configuring Simple vs. Batch export.

@alanwest alanwest requested a review from a team November 14, 2020 00:02
@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #1540 (b1187b5) into master (c409b89) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1540      +/-   ##
==========================================
- Coverage   81.01%   80.97%   -0.04%     
==========================================
  Files         235      235              
  Lines        6414     6414              
==========================================
- Hits         5196     5194       -2     
- Misses       1218     1220       +2     
Impacted Files Coverage Δ
...rc/OpenTelemetry.Exporter.Jaeger/JaegerExporter.cs 84.94% <ø> (ø)
...rc/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs 88.04% <ø> (ø)
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 76.47% <0.00%> (-5.89%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
...us/Implementation/PrometheusExporterEventSource.cs 72.72% <0.00%> (+9.09%) ⬆️

@cijothomas
Copy link
Member

I also believe there is a plan to apply the pattern started with Zipkin in #1504 to both Jaeger and Otlp for configuring Simple vs. Batch export.

Yes. @Austin-Tan is adding this.

@cijothomas cijothomas merged commit 4c7d2ae into open-telemetry:master Nov 14, 2020
@alanwest alanwest deleted the alanwest/make-exporters-consistent branch March 9, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants