Resource attributes fix

src/OpenTelemetry/CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+* Resource Attributes fixed to allow the values of key-value pairs to be of any
+  object type, matching the behavior of Activity's SetTag method.
 * The following extension methods on `ResourceBuilder` has been moved from the
   `OpenTelemetry` namespace to the `OpenTelemetry.Resources` namespace:
   `AddEnvironmentVariableDetector`, `AddAttributes`, `AddService`, and

src/OpenTelemetry/Resources/Resource.cs

@@ -101,28 +101,33 @@ private static KeyValuePair<string, object> SanitizeAttribute(KeyValuePair<strin
                 sanitizedKey = attribute.Key;
             }
 
-            object sanitizedValue;
-            if (!IsValidValue(attribute.Value))
-            {
-                OpenTelemetrySdkEventSource.Log.InvalidArgument("Create resource", "attribute value", "Attribute value should be a non-null string, long, bool or double.");
-                sanitizedValue = string.Empty;
-            }
-            else
-            {
-                sanitizedValue = attribute.Value;
-            }
+            object sanitizedValue = SanitizeValue(attribute.Value);
 
             return new KeyValuePair<string, object>(sanitizedKey, sanitizedValue);
         }
 
-        private static bool IsValidValue(object value)
+        private static object SanitizeValue(object value)
         {
-            if (value != null && (value is string || value is bool || value is long || value is double))
+            if (value != null)
             {
-                return true;
+                if (value is string || value is bool || value is long || value is double)
+                {
+                    return value;
+                }
+
+                if (value is int)
+                {
+                    return System.Convert.ToInt64(value);
+                }
+
+                if (value is float)
+                {
+                    return System.Convert.ToDouble(value);
+                }
             }
 
-            return false;
+            OpenTelemetrySdkEventSource.Log.InvalidArgument("Create resource", "attribute value", "Attribute value should be a non-null primitive or homogeneous array of primitives.");
+            return string.Empty;
         }
     }
 }

test/OpenTelemetry.Tests/Resources/ResourceTest.cs

@@ -158,7 +158,6 @@ public void CreateResource_NotSupportedAttributeTypes()
                 { "dynamic", new { } },
                 { "array", new int[1] },
                 { "complex", this },
-                { "float", 0.1f },
             };
 
             var resource = new Resource(attributes);
@@ -167,7 +166,6 @@ public void CreateResource_NotSupportedAttributeTypes()
             Assert.Contains(new KeyValuePair<string, object>("dynamic", string.Empty), resource.Attributes);
             Assert.Contains(new KeyValuePair<string, object>("array", string.Empty), resource.Attributes);
             Assert.Contains(new KeyValuePair<string, object>("complex", string.Empty), resource.Attributes);
-            Assert.Contains(new KeyValuePair<string, object>("float", string.Empty), resource.Attributes);
         }
 
         [Fact]