-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Part1] Support Activity Status and status description in Zipkin Exporter. #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yun-Ting
changed the title
[Part1] Support ActivityStatus and ActivityStatusDescription for Zipkin Exporter.
[Part1] Support ActivityStatus and ActivityStatusDescription in Zipkin Exporter.
Mar 10, 2022
Yun-Ting
changed the title
[Part1] Support ActivityStatus and ActivityStatusDescription in Zipkin Exporter.
[Part1] Support ActivityStatus and status description in Zipkin Exporter.
Mar 10, 2022
Yun-Ting
changed the title
[Part1] Support ActivityStatus and status description in Zipkin Exporter.
[Part1] Support Activity Status and status description in Zipkin Exporter.
Mar 10, 2022
Codecov Report
@@ Coverage Diff @@
## main #3003 +/- ##
==========================================
+ Coverage 84.71% 84.75% +0.03%
==========================================
Files 259 259
Lines 9121 9142 +21
==========================================
+ Hits 7727 7748 +21
Misses 1394 1394
|
src/OpenTelemetry.Exporter.Zipkin/Implementation/ZipkinActivityConversionExtensions.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.Zipkin.Tests/Implementation/ZipkinActivityConversionTest.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.Zipkin.Tests/Implementation/ZipkinActivityConversionTest.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.Zipkin/Implementation/ZipkinActivityConversionExtensions.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.Zipkin/Implementation/ZipkinActivityConversionExtensions.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.Zipkin/Implementation/ZipkinActivityConversionExtensions.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.Zipkin/Implementation/ZipkinActivityConversionExtensions.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.Zipkin/Implementation/ZipkinActivityConversionExtensions.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Mar 15, 2022
src/OpenTelemetry.Exporter.Zipkin/Implementation/ZipkinActivityConversionExtensions.cs
Show resolved
Hide resolved
cijothomas
reviewed
Mar 15, 2022
test/OpenTelemetry.Exporter.Zipkin.Tests/Implementation/ZipkinActivityConversionTest.cs
Show resolved
Hide resolved
cijothomas
reviewed
Mar 18, 2022
cijothomas
reviewed
Mar 18, 2022
test/OpenTelemetry.Exporter.Zipkin.Tests/ZipkinExporterTests.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Mar 22, 2022
src/OpenTelemetry.Exporter.Zipkin/Implementation/ZipkinActivityConversionExtensions.cs
Show resolved
Hide resolved
cijothomas
reviewed
Mar 22, 2022
src/OpenTelemetry.Exporter.Zipkin/Implementation/ZipkinActivityConversionExtensions.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Mar 22, 2022
cijothomas
approved these changes
Mar 22, 2022
Co-authored-by: Cijo Thomas <[email protected]>
This was referenced Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes parts of #2569.
Added support for Activity.Status/Description in ZipkinExporter.
System.Diagnostic.DiagnosticSource version 6.0.0 introduced native support for storing status/description in the Activity itself.
This PR modified the exporter to retrieve status from the newly added fields if it was set.
To maintain backward compatibility, the control flow would fell back to retrieve status from the activityTags if the native status/description were not set.
Background : Please review Console.Exporter where the same logic were exercised: #3061.
Next items : Add similar support for OTLP/Jaeger Exporters.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes