Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Part1] Support Activity Status and status description in Zipkin Exporter. #3003

Merged
merged 33 commits into from
Mar 22, 2022

Conversation

Yun-Ting
Copy link
Contributor

@Yun-Ting Yun-Ting commented Mar 10, 2022

Fixes parts of #2569.

Added support for Activity.Status/Description in ZipkinExporter.
System.Diagnostic.DiagnosticSource version 6.0.0 introduced native support for storing status/description in the Activity itself.

This PR modified the exporter to retrieve status from the newly added fields if it was set.
To maintain backward compatibility, the control flow would fell back to retrieve status from the activityTags if the native status/description were not set.

Background : Please review Console.Exporter where the same logic were exercised: #3061.

Next items : Add similar support for OTLP/Jaeger Exporters.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@Yun-Ting Yun-Ting requested a review from a team March 10, 2022 01:03
@Yun-Ting Yun-Ting changed the title [Part1] Support ActivityStatus and ActivityStatusDescription for Zipkin Exporter. [Part1] Support ActivityStatus and ActivityStatusDescription in Zipkin Exporter. Mar 10, 2022
@Yun-Ting Yun-Ting changed the title [Part1] Support ActivityStatus and ActivityStatusDescription in Zipkin Exporter. [Part1] Support ActivityStatus and status description in Zipkin Exporter. Mar 10, 2022
@Yun-Ting Yun-Ting changed the title [Part1] Support ActivityStatus and status description in Zipkin Exporter. [Part1] Support Activity Status and status description in Zipkin Exporter. Mar 10, 2022
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #3003 (ac081d7) into main (bdcf942) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head ac081d7 differs from pull request most recent head 578d445. Consider uploading reports for the commit 578d445 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3003      +/-   ##
==========================================
+ Coverage   84.71%   84.75%   +0.03%     
==========================================
  Files         259      259              
  Lines        9121     9142      +21     
==========================================
+ Hits         7727     7748      +21     
  Misses       1394     1394              
Impacted Files Coverage Δ
...plementation/ZipkinActivityConversionExtensions.cs 99.12% <100.00%> (+0.19%) ⬆️

@Yun-Ting Yun-Ting closed this Mar 10, 2022
@Yun-Ting Yun-Ting reopened this Mar 10, 2022
@Yun-Ting Yun-Ting closed this Mar 11, 2022
@Yun-Ting Yun-Ting reopened this Mar 11, 2022
@cijothomas cijothomas added this to the 1.2.0 milestone Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants