Adding conditional check for PublicApiAnalyzers. #3497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #3497 +/- ##
==========================================
+ Coverage 86.28% 86.34% +0.06%
==========================================
Files 270 270
Lines 9865 9865
==========================================
+ Hits 8512 8518 +6
+ Misses 1353 1347 -6
|
cijothomas
reviewed
Jul 27, 2022
build/Common.prod.props
Outdated
| @@ -1,7 +1,7 @@ | |||
| <Project> | |||
| <Import Project=".\Common.props" /> | |||
|
|
|||
| <ItemGroup> | |||
| <ItemGroup Condition="'$(ForRelease)' == 'true'"> | |||
There was a problem hiding this comment.
It will be referenced in the Prometheus shared project.
See #3430 (comment)
There was a problem hiding this comment.
Maybe we can shove the shared files under the Prometheus HttpListener project, and have the ASP.NET Core binding stealing from it?
It looks like we have a problem that is not generic, and here we try to solve it by abstraction and generalization (which doesn't seem to pay off IMHO) 😸
There was a problem hiding this comment.
would Condition="$(MSBuildProjectName.EndsWith('.Shared'))" work?
There was a problem hiding this comment.
@TimothyMothra, it works!
reyang
requested changes
Jul 27, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Not all projects under src/ are meant for releasing.
The
OpenTelemetry.Exporter.Prometheus.Sharedproject in this PR https://github.com/open-telemetry/opentelemetry-dotnet/pull/3430/files is one example.PublicApi documents are not required for projects not for release.
Thus, adding conditional check for PublicApiAnalyzers for the projects not meant for releasing to utilize it.