-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Not for merging] Phase out Grpc package for OTLP Exporter. #3573
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3573 +/- ##
==========================================
- Coverage 87.46% 87.29% -0.18%
==========================================
Files 278 278
Lines 10082 10096 +14
==========================================
- Hits 8818 8813 -5
- Misses 1264 1283 +19
|
{ | ||
if (options.Endpoint.Scheme != Uri.UriSchemeHttp && options.Endpoint.Scheme != Uri.UriSchemeHttps) | ||
{ | ||
throw new NotSupportedException($"Endpoint URI scheme ({options.Endpoint.Scheme}) is not supported. Currently only \"http\" and \"https\" are supported."); | ||
} | ||
|
||
#if NETSTANDARD2_1 || NET6_0_OR_GREATER | ||
return GrpcChannel.ForAddress(options.Endpoint); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests.OtlpExporterOptionsExtensionsTests.GetTraceExportClient_SupportedProtocol_ReturnsCorrectExportClient(protocol: Grpc, expectedExportClientType: typeof(OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation.ExportClient.OtlpGrpcTraceExportClient))
Source: OtlpExporterOptionsExtensionsTests.cs line 91
Duration: 1.2 sec
Message:
System.PlatformNotSupportedException : gRPC requires extra configuration on .NET implementations that don't support gRPC over HTTP/2. An HTTP provider must be specified using GrpcChannelOptions.HttpHandler.The configured HTTP provider must either support HTTP/2 or be configured to use gRPC-Web. See https://aka.ms/aspnet/grpc/netstandard for details.
Stack Trace:
HttpHandlerFactory.CreatePrimaryHandler()
GrpcChannel.CreateInternalHttpInvoker(HttpMessageHandler handler)
GrpcChannel.ctor(Uri address, GrpcChannelOptions channelOptions)
GrpcChannel.ForAddress(Uri address, GrpcChannelOptions channelOptions)
GrpcChannel.ForAddress(Uri address)
OtlpExporterOptionsExtensions.CreateChannel(OtlpExporterOptions options) line 39
OtlpGrpcTraceExportClient.ctor(OtlpExporterOptions options, TraceServiceClient traceServiceClient) line 39
OtlpExporterOptionsExtensions.GetTraceExportClient(OtlpExporterOptions options) line 81
OtlpExporterOptionsExtensionsTests.GetTraceExportClient_SupportedProtocol_ReturnsCorrectExportClient(OtlpExportProtocol protocol, Type expectedExportClientType) line 106
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Working towards #3421