Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Not for merging] Phase out Grpc package for OTLP Exporter. #3573

Closed
wants to merge 3 commits into from

Conversation

Yun-Ting
Copy link
Contributor

Working towards #3421

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #3573 (34c7f9d) into main (99b49b6) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3573      +/-   ##
==========================================
- Coverage   87.46%   87.29%   -0.18%     
==========================================
  Files         278      278              
  Lines       10082    10096      +14     
==========================================
- Hits         8818     8813       -5     
- Misses       1264     1283      +19     
Impacted Files Coverage Δ
...mentation/ExportClient/BaseOtlpGrpcExportClient.cs 83.33% <ø> (ø)
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 35.71% <ø> (-42.86%) ⬇️
...TelemetryProtocol/OtlpExporterOptionsExtensions.cs 97.93% <100.00%> (+0.21%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 36.36% <0.00%> (-40.91%) ⬇️
...Propagators/OpenTelemetryPropagatorsEventSource.cs 87.50% <0.00%> (-12.50%) ⬇️
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 91.20% <0.00%> (-3.30%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
src/OpenTelemetry/Metrics/CircularBufferBuckets.cs 100.00% <0.00%> (ø)
... and 6 more

{
if (options.Endpoint.Scheme != Uri.UriSchemeHttp && options.Endpoint.Scheme != Uri.UriSchemeHttps)
{
throw new NotSupportedException($"Endpoint URI scheme ({options.Endpoint.Scheme}) is not supported. Currently only \"http\" and \"https\" are supported.");
}

#if NETSTANDARD2_1 || NET6_0_OR_GREATER
return GrpcChannel.ForAddress(options.Endpoint);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests.OtlpExporterOptionsExtensionsTests.GetTraceExportClient_SupportedProtocol_ReturnsCorrectExportClient(protocol: Grpc, expectedExportClientType: typeof(OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation.ExportClient.OtlpGrpcTraceExportClient))
 Source: OtlpExporterOptionsExtensionsTests.cs line 91
 Duration: 1.2 sec

Message: 
System.PlatformNotSupportedException : gRPC requires extra configuration on .NET implementations that don't support gRPC over HTTP/2. An HTTP provider must be specified using GrpcChannelOptions.HttpHandler.The configured HTTP provider must either support HTTP/2 or be configured to use gRPC-Web. See https://aka.ms/aspnet/grpc/netstandard for details.

Stack Trace: 
HttpHandlerFactory.CreatePrimaryHandler()
GrpcChannel.CreateInternalHttpInvoker(HttpMessageHandler handler)
GrpcChannel.ctor(Uri address, GrpcChannelOptions channelOptions)
GrpcChannel.ForAddress(Uri address, GrpcChannelOptions channelOptions)
GrpcChannel.ForAddress(Uri address)
OtlpExporterOptionsExtensions.CreateChannel(OtlpExporterOptions options) line 39
OtlpGrpcTraceExportClient.ctor(OtlpExporterOptions options, TraceServiceClient traceServiceClient) line 39
OtlpExporterOptionsExtensions.GetTraceExportClient(OtlpExporterOptions options) line 81
OtlpExporterOptionsExtensionsTests.GetTraceExportClient_SupportedProtocol_ReturnsCorrectExportClient(OtlpExportProtocol protocol, Type expectedExportClientType) line 106

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Aug 23, 2022
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant