Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConsoleActivityExporter output alignment #3674

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

oboukli
Copy link
Contributor

@oboukli oboukli commented Sep 19, 2022

Changes

Fixes text alignment and whitespaces of the console exporter output

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 19, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: oboukli / name: Omar Boukli-Hacene (ddba5a9)

@oboukli oboukli force-pushed the fix-output-alignment branch from 6741af3 to ddba5a9 Compare September 19, 2022 16:05
@oboukli oboukli force-pushed the fix-output-alignment branch from ddba5a9 to 17a4b01 Compare September 19, 2022 18:31
@oboukli oboukli marked this pull request as ready for review September 19, 2022 18:32
@oboukli oboukli requested a review from a team September 19, 2022 18:32
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #3674 (17a4b01) into main (78e3842) will increase coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3674      +/-   ##
==========================================
+ Coverage   87.63%   87.72%   +0.08%     
==========================================
  Files         283      283              
  Lines       10286    10286              
==========================================
+ Hits         9014     9023       +9     
+ Misses       1272     1263       -9     
Impacted Files Coverage Δ
src/OpenTelemetry/Logs/Pool/LogRecordSharedPool.cs 78.94% <0.00%> (-21.06%) ⬇️
src/OpenTelemetry/Logs/OpenTelemetryLogger.cs 86.66% <0.00%> (-2.23%) ⬇️
...tpListener/Internal/PrometheusCollectionManager.cs 72.52% <0.00%> (-2.20%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 97.65% <0.00%> (+0.78%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (+2.94%) ⬆️
...metryProtocol/Implementation/ActivityExtensions.cs 95.05% <0.00%> (+3.29%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️
...tation/OpenTelemetryProtocolExporterEventSource.cs 85.00% <0.00%> (+10.00%) ⬆️
...Propagators/OpenTelemetryPropagatorsEventSource.cs 100.00% <0.00%> (+12.50%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 77.27% <0.00%> (+18.18%) ⬆️
... and 1 more

@cijothomas cijothomas merged commit f45206b into open-telemetry:main Sep 19, 2022
@oboukli oboukli deleted the fix-output-alignment branch September 20, 2022 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants