-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phased out Grpc package for OTLP Exporter. #3885
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3885 +/- ##
=======================================
Coverage 87.34% 87.34%
=======================================
Files 279 279
Lines 10782 10783 +1
=======================================
+ Hits 9417 9418 +1
Misses 1365 1365
|
<ItemGroup> | ||
<ProjectReference Include="$(RepoRoot)\src\OpenTelemetry\OpenTelemetry.csproj" /> | ||
<PackageReference Include="Google.Protobuf" Version="$(GoogleProtobufPkgVer)" /> | ||
<PackageReference Include="Grpc.Tools" Version="$(GrpcToolsPkgVer)" PrivateAssets="all" /> | ||
<PackageReference Include="Grpc.Net.Client" Version="$(GrpcNetClientPkgVer)" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the primary concern here is that this is probably a breaking change for some users. Consider .NET Framework users for whom things are working just fine today, but with this change they now have to configure the HttpClient for things to work. Worst part is that they'll only find this out at runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One idea we'd discussed in the past is to introduce separate OTLP/gRPC and OTLP/HTTP exporter packages. Something like
OpenTelemetry.Exporter.OpenTelemetryProtocol.Grpc
: This package would only depend on the newGrpc.Net.Client
as you've done here. The benefit of it being a new package is that it won't break existing users.OpenTelemetry.Exporter.OpenTelemetryProtocol.Http
: This could be done as a separate effort. Mostly just provides symmetry, but also reduces the number of transitive dependencies for users who don't want to use gRPC.
Fixes #3421.
Changes
HttpClient
as a hard requirement for configuringGrpcChannelOptions
.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes