Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove FormatException in tests and docs (part2) #4099

Merged
merged 3 commits into from
Jan 25, 2023
Merged

remove FormatException in tests and docs (part2) #4099

merged 3 commits into from
Jan 25, 2023

Conversation

TimothyMothra
Copy link
Contributor

Fixes #3690.

Follow up to PR #4095

Changes

  • reenable tests disabled in previous PR.
  • cleanup tests to assert default value after setting an invalid value for Environment Variables.
  • cleanup docs.

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@TimothyMothra TimothyMothra requested a review from a team January 23, 2023 19:39
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #4099 (112008d) into main (03af717) will increase coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4099      +/-   ##
==========================================
+ Coverage   85.46%   85.55%   +0.08%     
==========================================
  Files         292      292              
  Lines       11306    11306              
==========================================
+ Hits         9663     9673      +10     
+ Misses       1643     1633      -10     
Impacted Files Coverage Δ
...Telemetry.Exporter.Jaeger/JaegerExporterOptions.cs 100.00% <ø> (ø)
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 100.00% <ø> (ø)
...Telemetry.Exporter.Zipkin/ZipkinExporterOptions.cs 100.00% <ø> (ø)
...metry/Trace/BatchExportActivityProcessorOptions.cs 100.00% <ø> (ø)
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+5.88%) ⬆️
.../OpenTelemetry/Internal/ConfigurationExtensions.cs 100.00% <0.00%> (+12.50%) ⬆️
...Propagators/OpenTelemetryPropagatorsEventSource.cs 100.00% <0.00%> (+12.50%) ⬆️

@TimothyMothra TimothyMothra changed the title cleanup FormatException (part2) remove FormatException in tests and docs (part2) Jan 24, 2023
@cijothomas cijothomas merged commit ff6efe7 into open-telemetry:main Jan 25, 2023
@TimothyMothra TimothyMothra deleted the 3690_FormatException2 branch January 25, 2023 21:38
aunikitin pushed a commit to aunikitin/opentelemetry-dotnet that referenced this pull request Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormatException is thrown when an invalid env var value is set
3 participants