Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed not used file from OTLP project #4280

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Mar 7, 2023

Towards #3421 (comment)

Cleanup projects before split to HTTP and gRPC.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

@Kielek Kielek requested a review from a team March 7, 2023 13:04
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #4280 (03e5c05) into main (f3dab75) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4280      +/-   ##
==========================================
- Coverage   84.31%   84.28%   -0.04%     
==========================================
  Files         296      296              
  Lines       11791    11791              
==========================================
- Hits         9942     9938       -4     
- Misses       1849     1853       +4     
Impacted Files Coverage Δ
...tation/OpenTelemetryProtocolExporterEventSource.cs 85.00% <0.00%> (-15.00%) ⬇️
...porter.OpenTelemetryProtocol/OtlpMetricExporter.cs 72.72% <0.00%> (-13.64%) ⬇️
...p/Implementation/HttpInstrumentationEventSource.cs 76.00% <0.00%> (+4.00%) ⬆️
...lementation/SqlClientInstrumentationEventSource.cs 75.00% <0.00%> (+4.16%) ⬆️

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cijothomas cijothomas merged commit 6ffefb7 into open-telemetry:main Mar 7, 2023
@Kielek Kielek deleted the otlp-nullability/part-0 branch March 7, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants