-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opentracing shim noop cases #4668
Merged
alanwest
merged 8 commits into
open-telemetry:main
from
pjanotti:opentracing-shim-noop-cases
Jul 21, 2023
Merged
Opentracing shim noop cases #4668
alanwest
merged 8 commits into
open-telemetry:main
from
pjanotti:opentracing-shim-noop-cases
Jul 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4668 +/- ##
==========================================
- Coverage 85.06% 85.03% -0.04%
==========================================
Files 314 314
Lines 12747 12721 -26
==========================================
- Hits 10843 10817 -26
Misses 1904 1904
|
alanwest
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kielek
approved these changes
Jul 21, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2787
Changes
TelemetrySpan.NoopInstance
has an invalid span context the shim should not raise an exception: it is an expected scenario.Activity
and various sampling configurations to prevent similar regressions in the future.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes