[OpenTracing.Shim] TracerShim constructor #4812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
force-pushed
the
opentracing-shim-spec
branch
from
db85ab8 to
2ae8e1a
Compare
Codecov Report
@@ Coverage Diff @@
## main #4812 +/- ##
==========================================
- Coverage 83.96% 83.82% -0.14%
==========================================
Files 293 293
Lines 11966 11977 +11
==========================================
- Hits 10047 10040 -7
- Misses 1919 1937 +18
|
pjanotti
approved these changes
Aug 30, 2023
utpilla
approved these changes
Aug 30, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4727
Changes
TracerShim constructor met https://github.com/open-telemetry/opentelemetry-specification/blob/90eec0ffd8e52dddbd308e346cd5098f611164dd/specification/compatibility/opentracing.md
Old constructor marked as obsolete. It can be removed now/after this release.
2 new constructors to met criteria. If there is no propagator, the default one is used.
Unit tests covers only non-obsolete constructor.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes