-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Enrich and Filter for ASP.NET Core metrics #4981
Merged
CodeBlanch
merged 13 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/remove-enrich-filter-asp.netcore
Oct 23, 2023
Merged
Remove Enrich and Filter for ASP.NET Core metrics #4981
CodeBlanch
merged 13 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/remove-enrich-filter-asp.netcore
Oct 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main open-telemetry/opentelemetry-dotnet#4981 +/- ##
==========================================
+ Coverage 83.34% 83.41% +0.06%
==========================================
Files 295 295
Lines 12378 12336 -42
==========================================
- Hits 10317 10290 -27
+ Misses 2061 2046 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cijothomas
reviewed
Oct 23, 2023
cijothomas
reviewed
Oct 23, 2023
cijothomas
reviewed
Oct 23, 2023
Co-authored-by: Cijo Thomas <[email protected]>
Co-authored-by: Cijo Thomas <[email protected]>
cijothomas
reviewed
Oct 23, 2023
cijothomas
reviewed
Oct 23, 2023
cijothomas
approved these changes
Oct 23, 2023
utpilla
reviewed
Oct 23, 2023
src/OpenTelemetry.Instrumentation.AspNetCore/AspNetCoreMetricsInstrumentationOptions.cs
Outdated
Show resolved
Hide resolved
utpilla
approved these changes
Oct 23, 2023
…InstrumentationOptions.cs Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
CodeBlanch
reviewed
Oct 23, 2023
Co-authored-by: Mikel Blanchard <[email protected]>
2 tasks
3 tasks
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #open-telemetry/opentelemetry-dotnet-contrib#1733
Design discussion issue #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes