Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url.scheme to http.client.request.duration metric #4989

Merged

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Oct 26, 2023

Fixes #
Design discussion issue #

Changes

Adding url.scheme to http.client.request.duration that was added recently. The attribute is required.
Spec link: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-metrics.md#metric-httpclientrequestduration

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #4989 (0d4ffde) into main (cd8de07) will increase coverage by 0.18%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 0d4ffde differs from pull request most recent head c9b26b1. Consider uploading reports for the commit c9b26b1 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4989      +/-   ##
==========================================
+ Coverage   83.38%   83.57%   +0.18%     
==========================================
  Files         295      295              
  Lines       12337    12339       +2     
==========================================
+ Hits        10287    10312      +25     
+ Misses       2050     2027      -23     
Flag Coverage Δ
unittests 83.57% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ementation/HttpHandlerMetricsDiagnosticListener.cs 97.67% <100.00%> (+0.05%) ⬆️
...plementation/HttpWebRequestActivitySource.netfx.cs 82.96% <100.00%> (+0.03%) ⬆️

... and 5 files with indirect coverage changes

@vishweshbankwar vishweshbankwar marked this pull request as ready for review October 26, 2023 19:03
@vishweshbankwar vishweshbankwar requested a review from a team October 26, 2023 19:03
@utpilla utpilla merged commit f7b4ae1 into open-telemetry:main Oct 26, 2023
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants