-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HttpClient] update network.protocol.version
values as per specification
#5006
Merged
utpilla
merged 6 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/fix-network-protocol-version-httpclient
Nov 10, 2023
Merged
[HttpClient] update network.protocol.version
values as per specification
#5006
utpilla
merged 6 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/fix-network-protocol-version-httpclient
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5006 +/- ##
==========================================
- Coverage 83.52% 83.33% -0.19%
==========================================
Files 296 296
Lines 12467 12475 +8
==========================================
- Hits 10413 10396 -17
- Misses 2054 2079 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
Issues and pull requests which have been flagged for closing due to inactivity
label
Nov 7, 2023
vishweshbankwar
changed the title
[HttpClient] fix network.protocol.version
[HttpClient] update Nov 10, 2023
network.protocol.version
values as per specification
github-actions
bot
removed
the
Stale
Issues and pull requests which have been flagged for closing due to inactivity
label
Nov 10, 2023
…tps://github.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/fix-network-protocol-version-httpclient
utpilla
reviewed
Nov 10, 2023
utpilla
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue #
Changes
Assign values as per spec https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#common-attributes
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes