-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HttpClient and ASP.NET Core] Fix failures due to changes in .NET8.0 stable release #5049
[HttpClient and ASP.NET Core] Fix failures due to changes in .NET8.0 stable release #5049
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5049 +/- ##
==========================================
- Coverage 83.35% 83.34% -0.02%
==========================================
Files 296 296
Lines 12474 12473 -1
==========================================
- Hits 10398 10395 -3
- Misses 2076 2078 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -118,6 +118,10 @@ Released 2023-Oct-26 | |||
definition. | |||
([#4990](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4990)) | |||
|
|||
* `dns.lookups.duration` metric is renamed to `dns.lookup.duration`. This change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting...there is no code change here. Do we plan to keep updating changelog in otel instrumentation, for every change in .net repo? Or this is a one-time thing and we dont expect anything futher?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned this one because we have a changelog entry in previous release with different name. In future, I don't think we need to mention every change. Except when the change might impact users moving from lower version to net8 or above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going forward, I think we should simply update the README to point to the Microsoft official docs which lists these metrics and let users track the changes from there.
Fixes #
Design discussion issue #
Changes
Fixes couple of failures due to upgrade to .NET8.0. These are expected changes based on the issues that were fixed between rc and table release.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes