-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tools] Stress test improvements #5381
[tools] Stress test improvements #5381
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5381 +/- ##
==========================================
- Coverage 83.38% 83.22% -0.16%
==========================================
Files 297 279 -18
Lines 12531 11961 -570
==========================================
- Hits 10449 9955 -494
+ Misses 2082 2006 -76
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -145,10 +181,13 @@ public static void Stress(int concurrency = 0, int prometheusPort = 0) | |||
var cntCpuCyclesTotal = GetCpuCycles(); | |||
var cpuCyclesPerLoopTotal = cntLoopsTotal == 0 ? 0 : cntCpuCyclesTotal / cntLoopsTotal; | |||
Console.WriteLine("Stopping the stress test..."); | |||
Console.WriteLine($"* Total Runaway Time (seconds) {watchForTotal.Elapsed.TotalSeconds:n0}"); | |||
Console.WriteLine($"* Total Runway Time (Seconds) {watchForTotal.Elapsed.TotalSeconds:n0}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the README file as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to ask, was "Runaway" intentional? In the running output we have "Runway" so it seemed like a typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what's the perfect term, I just picked a term that seems to fit the intention http://osr507doc.xinuos.com/en/HANDBOOK/runaway_proc.html. (e.g. if user keeps this process, it'll consume lots of system resources)
The comment here is more emphasizing on "whatever term we choose, we have to be consistent".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just switched it to "Running Time" in both spots. Seemed less likely to cause any confusion but I don't absolutely love it 😄
Let me do README updates in a follow-up as this is getting a bit big already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to ask, was "Runaway" intentional? In the running output we have "Runway" so it seemed like a typo.
test/OpenTelemetry.Tests.Stress.Metrics/OpenTelemetry.Tests.Stress.Metrics.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some improvements to the stress tests I made to help in testing #5364.
Changes
OpenTelemetry.Tests.Stress.Metrics.exe -t Counter -v -o -e -d 300
Options
Shared by all signals:
Metrics: