-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shims, W3C.Tests] Nullable #5797
[Shims, W3C.Tests] Nullable #5797
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5797 +/- ##
==========================================
+ Coverage 83.38% 86.22% +2.84%
==========================================
Files 297 257 -40
Lines 12531 11169 -1362
==========================================
- Hits 10449 9631 -818
+ Misses 2082 1538 -544
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@CodeBlanch, could you please also check and merge?
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
test/OpenTelemetry.Shims.OpenTracing.Tests/SpanBuilderShimTests.cs
Outdated
Show resolved
Hide resolved
@@ -32,7 +32,7 @@ internal sealed class SpanBuilderShim : ISpanBuilder | |||
/// <summary> | |||
/// The OpenTelemetry attributes. These correspond to OpenTracing Tags. | |||
/// </summary> | |||
private readonly List<KeyValuePair<string, object>> attributes = new(); | |||
private readonly SpanAttributes attributes = new(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :)
Towards #3958
Changes
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes