Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpCode for activity started and stop in OpenTelemetry-Sdk eventsource #6046

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add OpCode for activity started and stop in OpenTelemetry-Sdk eventsource #6046

wants to merge 2 commits into from

Conversation

xiaomi7732
Copy link

@xiaomi7732 xiaomi7732 commented Jan 3, 2025 •
edited
Loading

Hi maintainers,

OpenTelemetry-Sdk provides activity started / stopped events. How about adding OpCode on those events, making it easier to be discovered by the analysis tools?

Changes

Add opcode for activity start / stop to OpenTelemetry-Sdk event source.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@xiaomi7732 xiaomi7732 requested a review from a team as a code owner January 3, 2025 18:59
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 3, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Jan 3, 2025
@rajkumar-rangaraj
Copy link
Contributor

@xiaomi7732 Could you please check if you reviewed the previous PR #5387, where the feedback was provided for similar proposal?

@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas left review comments

@noahfalk noahfalk Awaiting requested review from noahfalk

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaomi7732 @rajkumar-rangaraj @cijothomas @noahfalk