-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental fixes #604
Experimental fixes #604
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
=======================================
Coverage 72.26% 72.26%
=======================================
Files 60 60
Lines 1904 1904
=======================================
Hits 1376 1376
Misses 528 528
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d7c345e
to
bfcb6d2
Compare
bfcb6d2
to
62299c5
Compare
52f18dc
to
15423f7
Compare
7e5f919
to
a6b9dd9
Compare
Unused because the CT suite name was duplicated, the same tests are covered in the opentelemetry_experimental tests
a6b9dd9
to
c406000
Compare
@tsloughter review suggestion applied and rebased on main, tests pass locally |
I think the failing test is a little bit flaky, it fails (not always) also on different PR (see for instance #609) |
Yup, I'm rerunning it.Should be fine. |
Co-authored-by: Tristan Sloughter <[email protected]>
Hey, can you send another PR with an update to the changelog? Sorry, I always forget to check this until I hit the merge button :) |
Also changes to experimental apps go into the main changelog? |
Yea, just under their names, so like |
A couple of improvements on the experimental applications.
Different contributions are split in different commits so if you prefer to accept only some of them I can discard the unwanted ones:
instrument_unit
to view criteria (see spec)