b3: Introduce New function and option type #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo and
XSAM
as code owners
pellared
commented
Jul 7, 2021
Codecov Report
@@ Coverage Diff @@
## main #868 +/- ##
=====================================
Coverage 75.3% 75.4%
=====================================
Files 68 69 +1
Lines 3054 3064 +10
=====================================
+ Hits 2301 2311 +10
Misses 613 613
Partials 140 140
|
MrAlias
reviewed
Jul 20, 2021
MrAlias
approved these changes
Jul 21, 2021
Aneurysm9
approved these changes
Jul 23, 2021
Merged
garrettwegan
referenced
this pull request
in garrettwegan/opentelemetry-go-contrib
Jul 28, 2021
* b3: Introduce option type * Update docs * Apply suggestions from code review Co-authored-by: Tyler Yahn <[email protected]> * Unexport b3.B3 * Use b3.New instead of b3.B3 * Fix lint errors Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Anthony Mirabella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Per #851
What
Adhere to https://github.com/open-telemetry/opentelemetry-go/blob/main/CONTRIBUTING.md#configuration
Other remarks
During the last SIG meeting, we agreed that we should have a single Go Module per propagator. This will be done in a dedicated PR.