Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenCensus bridge: GA improvements #4562

Closed
4 of 5 tasks
dashpole opened this issue Sep 26, 2023 · 1 comment
Closed
4 of 5 tasks

OpenCensus bridge: GA improvements #4562

dashpole opened this issue Sep 26, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@dashpole
Copy link
Contributor

dashpole commented Sep 26, 2023

Problem Statement

Make sure we are happy with the package API before we consider making a stable release.

Current potential problems:

  • NewTracer takes an OpenTelemetry Tracer, rather than an OpenTelemetry TracerProvider. Ideally, the bridge would always have the correct instrumentation scope, rather than relying on users to set it correctly.
  • NewTracer and NewMetricProducer do not accept Options. We should consider adding this in-case we need options in the future.
  • NewTracer needs to be assigned to the opencensus.DefaultTracer to function properly. It might be more helpful to users to do that for them.
  • opencensus.OTelSpanContextToOC and opencensus.OCSpanContextToOTel names are hard to read. Possibly opencensus.SpanContextFromOpenTelemetry and opencensus.SpanContextToOpenTelemetry?
  • Remove deprecated NewMetricExporter
@dashpole
Copy link
Contributor Author

dashpole commented Oct 3, 2023

I think we should leave the OCSpanContextToOTel names as-is. Either way, the names are going to be long, and I don't think users will need to use either of those functions often.

@dashpole dashpole closed this as completed Oct 3, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go: Metric OpenCensus Bridge (GA) Oct 3, 2023
@MrAlias MrAlias added this to the v1.20.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants