-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to opencensus bridge, and install tracer instead of returning #4567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
September 27, 2023 18:12
dashpole
force-pushed
the
opencensus_options
branch
2 times, most recently
from
September 27, 2023 18:15
577ff0d
to
2fb84c7
Compare
Codecov Report
@@ Coverage Diff @@
## main #4567 +/- ##
=======================================
- Coverage 81.3% 81.3% -0.1%
=======================================
Files 220 221 +1
Lines 17669 17686 +17
=======================================
+ Hits 14380 14391 +11
- Misses 2989 2995 +6
Partials 300 300
|
MadVikingGod
approved these changes
Sep 28, 2023
dashpole
force-pushed
the
opencensus_options
branch
from
September 28, 2023 15:07
24cd586
to
cae64aa
Compare
This was referenced Sep 29, 2023
MrAlias
reviewed
Sep 29, 2023
MrAlias
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4562
Changes: