Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use url.PathUnescape rather than url.QueryUnescape when parsing OTLP headers and resource attributes env vars #4698

Closed
pellared opened this issue Nov 8, 2023 · 2 comments
Closed

Use url.PathUnescape rather than url.QueryUnescape when parsing OTLP headers and resource attributes env vars #4698

pellared opened this issue Nov 8, 2023 · 2 comments
Assignees
@mikeblum
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
untracked

Comments

@pellared
Copy link
Member

pellared commented Nov 8, 2023

I noticed that the enhancement done in #4667 is probably also worth doing for:

  • parsing the OTEL_EXPORTER_OTLP_HEADERS, OTEL_EXPORTER_OTLP_TRACES_HEADERS, OTEL_EXPORTER_OTLP_METRICS_HEADERS env vars
  • parsing OTEL_RESOURCE_ATTRIBUTES env var
@pellared pellared added the enhancement New feature or request label Nov 8, 2023
@github-project-automation github-project-automation bot moved this to Needs triage in Go: Triage Nov 8, 2023
@pellared pellared moved this from Needs triage to Low priority in Go: Triage Nov 8, 2023
@pellared pellared added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 8, 2023
@mikeblum
Copy link
Contributor

mikeblum commented Nov 8, 2023

👋 happy to take this issue on for contribfest - otel at kubecon NA '23

mikeblum pushed a commit to mikeblum/opentelemetry-go that referenced this issue Nov 8, 2023
Use url.PathUnescape rather than url.QueryUnescape when parsing OTLP …
1d55805 
…headers and resource attributes env vars (open-telemetry#4698)
@mikeblum mikeblum mentioned this issue Nov 8, 2023
Merged
mikeblum added a commit to mikeblum/opentelemetry-go that referenced this issue Nov 8, 2023
@mikeblum
Use url.PathUnescape rather than url.QueryUnescape when parsing OTLP …
5eba783 
…headers and resource attributes env vars (open-telemetry#4698)
mikeblum added a commit to mikeblum/opentelemetry-go that referenced this issue Nov 8, 2023
@mikeblum
Use url.PathUnescape rather than url.QueryUnescape when parsing OTLP …
192db26 
…headers and resource attributes env vars (open-telemetry#4698)
mikeblum added a commit to mikeblum/opentelemetry-go that referenced this issue Nov 8, 2023
@mikeblum
Use url.PathUnescape rather than url.QueryUnescape when parsing OTLP …
9576ec7 
…headers and resource attributes env vars (open-telemetry#4698)
mikeblum added a commit to mikeblum/opentelemetry-go that referenced this issue Nov 9, 2023
@mikeblum
Use url.PathUnescape rather than url.QueryUnescape when parsing OTLP …
706ca80 
…headers and resource attributes env vars (open-telemetry#4698)
mikeblum added a commit to mikeblum/opentelemetry-go that referenced this issue Nov 9, 2023
@mikeblum
Use url.PathUnescape rather than url.QueryUnescape when parsing OTLP …
e7bc26d 
…headers and resource attributes env vars (open-telemetry#4698)
mikeblum added a commit to mikeblum/opentelemetry-go that referenced this issue Nov 9, 2023
@mikeblum
Use url.PathUnescape rather than url.QueryUnescape when parsing OTLP …
7011c66 
…headers and resource attributes env vars (open-telemetry#4698)
MrAlias pushed a commit that referenced this issue Nov 9, 2023
@mikeblum
Use url.PathUnescape rather than url.QueryUnescape when parsing OTLP …
be5064a 
…headers and resource attributes env vars (#4698) (#4699)
@pellared
Copy link
Member Author

Fixed by #4699

@github-project-automation github-project-automation bot moved this from Low priority to Closed in Go: Triage Nov 10, 2023
@XSAM XSAM added this to the untracked milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikeblum mikeblum

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Go: Triage
Status: Closed
Milestone
untracked
Development

No branches or pull requests
3 participants
@mikeblum @pellared @XSAM